Allow for more than 3 nomination votes if others are ticketed#3056
Merged
Conversation
This changes how we calculate whether we are ready for another vote in the talentpool autonomination system. Instead of hard-locking at 3 votes in the pool, we factor in whether an admin-task has been created for the vote (signified by a reaction with the 🎫 emoji). We allow for up to 10 votes to be in the pool total, which in theory allows 3 active votes and 7 votes waiting on the admin-task completion (though we should never hit this threshold realistically). This should allow for voting to be more or less continuous and ensure there is always new votes in the pool and we are not blocked on the completion of a Helpering/waiting for a Helper candidate to be available for a new vote to start. The thresholds are based on those suggested in the nomination-discussion moderator channel.
jb3
added
p: 2 - normal
Member
Author
|
Good spot on the tests, I've updated them now to add 2 new cases for "above active, below total" and "above active, above total". |
jchristgit
approved these changes
May 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes how we calculate whether we are ready for another vote in
the talentpool autonomination system.
Instead of hard-locking at 3 votes in the pool, we factor in whether an
admin-task has been created for the vote (signified by a reaction with
the 🎫 emoji).
We allow for up to 10 votes to be in the pool total, which in theory
allows 3 active votes and 7 votes waiting on the admin-task
completion (though we should never hit this threshold realistically).
This should allow for voting to be more or less continuous and ensure
there is always new votes in the pool and we are not blocked on the
completion of a Helpering/waiting for a Helper candidate to be available
for a new vote to start.
The thresholds are based on those suggested in the nomination-discussion
moderator channel.